Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #5049 #5057

Closed
wants to merge 1 commit into from
Closed

Issue #5049 #5057

wants to merge 1 commit into from

Conversation

Sid-80
Copy link

@Sid-80 Sid-80 commented Feb 11, 2023

Ace.d.ts: Autocomplete not working because of missing type declaration of TextInput.setAriaOptions

Added setAriaOptions() to Ace.d.ts :

export interface TextInput {
resetSelection(): void;
setAriaOption(activeDescendant: string, role: string): void;
}

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Ace.d.ts: Autocomplete not working because of missing type declaration of TextInput.setAriaOptions
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Base: 86.14% // Head: 86.14% // No change to project coverage 👍

Coverage data is based on head (ad42d08) compared to base (3250956).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5057   +/-   ##
=======================================
  Coverage   86.14%   86.14%           
=======================================
  Files         548      548           
  Lines       41692    41692           
  Branches     6563     6563           
=======================================
  Hits        35917    35917           
  Misses       5775     5775           
Flag Coverage Δ
unittests 86.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nightwing
Copy link
Member

The error shown in the linked issue is in browser developer tools, so it is not related to the type definitions.

@InspiredGuy
Copy link
Contributor

Thank you for the contribution @Sid-80 ! TextInput interface already exists at line 753, could you please add setAriaOption declaration there instead of creating a new interface?

@ghost
Copy link

ghost commented Feb 14, 2023

I have added the necessary change in my accesibility PR #5059

@InspiredGuy
Copy link
Contributor

another PR #5059 handled the same issue, which was targeted by this PR, so I'm closing this one as duplicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants